Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/python: improve reporting when a command fails #6718

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Aug 21, 2023

  • represent the command accurately using shell quoting;
  • show the exit code;
  • show both stdout and stderr.

Motivation and context

This helped me debug #6717.

How has this been tested?

Unit tests.

Checklist

  • I submit my changes into the develop branch
  • [ ] I have added a description of my changes into the CHANGELOG file
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@SpecLad SpecLad requested a review from azhavoro as a code owner August 21, 2023 12:03
@SpecLad SpecLad force-pushed the better-command-failure-display branch 2 times, most recently from a0dfd50 to f179de1 Compare August 21, 2023 12:18
* represent the command accurately using shell quoting;
* show the exit code;
* show both stdout and stderr.
@SpecLad SpecLad force-pushed the better-command-failure-display branch from f179de1 to c75a796 Compare August 22, 2023 10:45
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #6718 (c75a796) into develop (59ae3e5) will decrease coverage by 0.01%.
Report is 2 commits behind head on develop.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #6718      +/-   ##
===========================================
- Coverage    82.25%   82.25%   -0.01%     
===========================================
  Files          366      366              
  Lines        39767    39766       -1     
  Branches      3531     3531              
===========================================
- Hits         32712    32708       -4     
- Misses        7055     7058       +3     
Components Coverage Δ
cvat-ui 77.01% <ø> (-0.03%) ⬇️
cvat-server 86.81% <0.00%> (+<0.01%) ⬆️

@SpecLad SpecLad merged commit 9fb60b7 into develop Aug 22, 2023
35 checks passed
@SpecLad SpecLad deleted the better-command-failure-display branch August 22, 2023 15:11
jonybekov pushed a commit to tezzro/cvat that referenced this pull request Sep 6, 2023
* represent the command accurately using shell quoting;
* show the exit code;
* show both stdout and stderr.
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
* represent the command accurately using shell quoting;
* show the exit code;
* show both stdout and stderr.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants